aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 31394: Renaming storage.thrift job store structs.
Date Wed, 25 Feb 2015 01:49:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31394/#review73958
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Feb. 25, 2015, 1:06 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31394/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 1:06 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Renaming thrift structs and the `JobStore` to better reflect its cron-only purpose.
> 
> Purely IDE-driven renaming.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift d3b50d7511f385797cbb539e66e83a851c6bccf7

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java c8834215c6c621246e3436de734b95d9ced66537

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 916cb6dc4b8907ffaf6736f1d615bbc72611a589

>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java e7ee0cf0895c1c75c98c993e14716c7419a9eeec

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 199dc1123cd1966b1c8075e7a486efdf627c45f3

>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java fc8e2f4e75a33789b28588204cbbfd56b5d049a4

>   src/main/java/org/apache/aurora/scheduler/storage/JobStore.java 748b2cbce76258b3f4c454538b8d40a19e13e68e

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 41b7053b01f2105bbf9d5ee4616a0c3d0d91220a

>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 7a99afa656a0978d05848a31c73c2658a98d6918

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java ea4afb49e52aed1134cf6ca44bf53693a4d999df

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 0229b920ebb36353b8bf9d1ea360d7ff6f4dbf97

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 72b9895214aa372c4fd75e5bb6dee8485b3594f6

>   src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java ee88d7c03cc1d1f23ed6b2ef1e5cf5c7929a57c9

>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java aa2226651ba6c5d1b77c4861f734b4194dcbecf3

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c9ffc3871e1824ea39961c4a4d416e50d7e1f078

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java bc3a7c5061d97e13c7702329a168d416c3dd1bcc

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 31c25d04cd1b8f741649edea8424eb298738d895

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059626f742ce806fded754ef04a83e2eb5405ff2

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 7bef09e8217750908eb56d9010df79bb5fd050de

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java c3f8d1b4c96ae35ebfb157f46ae545c8d39c3602

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java d4c14afa7b7ea904f7a33a8747591ab8f1be5f9b

>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java b48994f40edea5e257e2816b1950d8a495d89aa6

>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 91789e7c203753054406296c41248a1fbf30d019

>   src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 0c73a9f78d3dfe4764c0e8513b85611313067368

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 31b75f41ef3cf1d32824afabec6f7ea79285973d

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 343106c24395911162657538c99a05b81d5ee2dc

>   src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 36809ac2e7e8924187eb2d9cbd69da58e7866681

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemJobStoreTest.java b9ade45bae6f76520789821733a58075ea6d0bd0

>   src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 6feddc3fc82da072d84bd69b16637144215415b7

> 
> Diff: https://reviews.apache.org/r/31394/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Also, test bidirectional upgrade in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message