aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.
Date Wed, 25 Feb 2015 00:27:45 GMT


> On Feb. 25, 2015, 12:17 a.m., Aurora ReviewBot wrote:
> > Master (cd681d9) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                                    role=role,
> >                                    jobKey=job_key.to_thrift() if job_key else
None,
> >                                    user=user,
> >                      >             updateStatuses=update_statuses))
> >                      E     TypeError: __init__() got an unexpected keyword
argument 'updateId'
> >                      
> >                      /tmp/user/20000/tmpTCKUtn/apache/aurora/client/api/__init__.py:230:
TypeError
> >                       generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.api.api.xml

> >                      ======= 2 failed, 9 passed in 0.74 seconds =======
> >                      src.test.python.apache.aurora.admin.admin                 
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.admin.host_maintenance      
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.admin.maintenance           
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.api.api              
                     .....   FAILURE
> >                      src.test.python.apache.aurora.client.api.updater          
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.base                 
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.binding_helper       
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.cli.config           
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.cli.cron             
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.cli.sla              
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.config               
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.factory              
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.hooks.non_hooked_api 
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_aurora_job_key  
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_cluster         
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_cluster_option  
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_clusters        
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_http_signaler   
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_pex_version     
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_shellify        
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_transport       
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.path_detector
                    .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.task_info   
                     .....   SUCCESS
> >                      src.test.python.apache.thermos.common.test_pathspec       
                     .....   SUCCESS
> >                      src.test.python.apache.thermos.core.test_runner_integration
                    .....   SUCCESS
> >                      src.test.python.apache.thermos.monitoring.test_disk       
                     .....   SUCCESS
> >                      
> > FAILURE
> > 
> > 
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

Okay, obviously i'll need to fold the python changes in here to keep the build green.  Updated
diff incoming.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review73945
-----------------------------------------------------------


On Feb. 25, 2015, 12:07 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31388/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 12:07 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1093
>     https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update thrift API and internal code to use JobUpdateSummary.key rather than job key and
id.
> 
> Note: This change will leave the client in a broken state w.r.t. the scheduler.  I will
hold commiting this change until i have another review ready to go that updates the client.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6a00ce2c30ce24851560c4d499c395194dbeed16

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 199dc1123cd1966b1c8075e7a486efdf627c45f3

>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java fc8e2f4e75a33789b28588204cbbfd56b5d049a4

>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83

>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 72b9895214aa372c4fd75e5bb6dee8485b3594f6

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java b9dce16fa705fc14b5af394f8edb6301c789aff4

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059626f742ce806fded754ef04a83e2eb5405ff2

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java d1bd3c975b2057b46597f38555c2a73d14835600

>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java b8c919585307e27f154782ee179153165458bed7

>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
c08f09a511e1fc631abdae50630b8b7ab10a440b 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql e6184dd2de0e86849d811ec05c168bbb4db8e8cd

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b79b07c23e00fab524aef21481070c5f09c9fa18

>   src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 81c8be7685854c47ed4a7c6deeffb6a0b80023ab

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java e969b972806bef9aa67729c8a35283df6145e687

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2405bb8ad379e355a7987e9bb4163e1693f18777

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 3ba6274b97393ac2228d3eac8ba1615cb57014f8

> 
> Diff: https://reviews.apache.org/r/31388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message