aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.
Date Tue, 24 Feb 2015 23:51:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review73936
-----------------------------------------------------------


This patch does not apply cleanly on master (cd681d9), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 24, 2015, 11:47 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31388/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 11:47 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1093
>     https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update thrift API and internal code to use JobUpdateSummary.key rather than job key and
id.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6a00ce2c30ce24851560c4d499c395194dbeed16

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java bb727214b19ec6074d04eacdd997832e50b756f9

>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java fc8e2f4e75a33789b28588204cbbfd56b5d049a4

>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83

>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 72b9895214aa372c4fd75e5bb6dee8485b3594f6

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 34763851cd59996559f160c57b00d23de3dc49b4

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d24b31bf1034c69ac8a9891aaa9b8653674ce0ce

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java d1bd3c975b2057b46597f38555c2a73d14835600

>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java b8c919585307e27f154782ee179153165458bed7

>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
c08f09a511e1fc631abdae50630b8b7ab10a440b 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql e6184dd2de0e86849d811ec05c168bbb4db8e8cd

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java eac2033cffc09f6a9e867a2499569b51d94f0705

>   src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 81c8be7685854c47ed4a7c6deeffb6a0b80023ab

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java daaa759ca5c2cda26802187698f0a33ceb0dd39f

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
5b0565e6477644047a237b8d185027a6fdc5c6a5 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2405bb8ad379e355a7987e9bb4163e1693f18777

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 3ba6274b97393ac2228d3eac8ba1615cb57014f8

> 
> Diff: https://reviews.apache.org/r/31388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message