aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 31176: Split out ReadOnlySchedulerImplTest.
Date Mon, 23 Feb 2015 22:45:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31176/#review73700
-----------------------------------------------------------

Ship it!


Master (277ac43) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 23, 2015, 10:41 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31176/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 10:41 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-808
>     https://issues.apache.org/jira/browse/AURORA-808
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Split out ReadOnlySchedulerImplTest.
> 
> * Factored out a common Fixtures class for Thrift test data (not married to the name).
> * Added a unit test for LoggingInterceptor (preferable to relying on SchedulerThriftInterfaceTest
to test it indirectly).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 6484642b6416466807f76267d66941c9cf7b3346

>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
15147757dfca889f5b5b5ec6967dda98ddfe3075 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/31176/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message