aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 31251: Fix swallowed exceptions in health check test.
Date Mon, 23 Feb 2015 19:50:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/
-----------------------------------------------------------

(Updated Feb. 23, 2015, 7:50 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
-------

Remove mixing of real and fake clocks in gc executor test.  Remove timeouts from clock convergence,
since those will be sources of flakiness.


Repository: aurora


Description
-------

Fix swallowed exceptions in health check test.  One of the health checkers was raising uncaught
exceptions on a separate thread.  The Python interpreter on CI *might* behave slightly differently
and fail here.  To be honest I've not been able to reproduce the CI behavior, so hopefully
buildbot can chime in here.


Diffs (updated)
-----

  src/main/python/apache/aurora/executor/common/health_checker.py 0d3365d395c65793b90ce96f277b7f4e4b1dcb99

  src/test/python/apache/aurora/executor/common/test_health_checker.py 4e09d309d402cf678c69d033e5219e9c8e4ccaaa

  src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6


Diff: https://reviews.apache.org/r/31251/diff/


Testing
-------

Ran the following about 100 times:

THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs' src/test/python/apache/aurora/executor/common:health_checker


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message