aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 31176: Split out ReadOnlySchedulerImplTest.
Date Mon, 23 Feb 2015 19:46:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31176/
-----------------------------------------------------------

(Updated Feb. 23, 2015, 11:45 a.m.)


Review request for Aurora.


Changes
-------

Fix checkstyle errors and rebase.


Repository: aurora


Description (updated)
-------

Split out ReadOnlySchedulerImplTest.

* Factored out a common Fixtures class for Thrift test data (not married to the name).
* Added a unit test for LoggingInterceptor (preferable to relying on SchedulerThriftInterfaceTest
to test it indirectly).


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 6484642b6416466807f76267d66941c9cf7b3346

  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 15147757dfca889f5b5b5ec6967dda98ddfe3075

  src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/31176/diff/


Testing (updated)
-------

./gradlew -Pq build


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message