aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.
Date Sat, 21 Feb 2015 00:53:46 GMT


> On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java, line 78
> > <https://reviews.apache.org/r/31248/diff/1/?file=871337#file871337line78>
> >
> >     Any reason to lower case these? I'd actually prefer upper cased (default) values.
This would be consistent with other places where we use enums (e.g. task_store_ASSIGNED).

Yeah, not sure why i did that.  Done.


> On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, line 216
> > <https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line216>
> >
> >     Should it rather be micros (given that the only current consumer accepts microseconds)?

Sure.  Also added a guard at the receiving side against <=0 delta in case of <1ms delivery
or clock skew.


> On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, line 199
> > <https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199>
> >
> >     Use StringBuilder instead to avoid heap churn.

javac is smart enough here

http://stackoverflow.com/questions/11942368/why-use-stringbuilder-explicitly-if-the-compiler-converts-string-concatenation-t


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/#review73351
-----------------------------------------------------------


On Feb. 21, 2015, 12:04 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31248/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1028
>     https://issues.apache.org/jira/browse/AURORA-1028
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Export stats for source and reason for LOST tasks, and status delivery latency.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 1d8f0128732756db74576ee669f6a2718fecc105

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffc30bb548706df7bec9e1502242890e9b5eb942

>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java 59ad9e65589c421cefb76f265446fa2885e6198c

>   src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d02c6b32841d5d39c5780e7a044079a38729effb

>   src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/31248/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message