aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 30749: Port GC executor to PathDetector interface
Date Sat, 21 Feb 2015 00:08:27 GMT


> On Feb. 10, 2015, 7:12 p.m., Joshua Cohen wrote:
> > src/main/python/apache/thermos/monitoring/garbage.py, line 120
> > <https://reviews.apache.org/r/30749/diff/9/?file=859049#file859049line120>
> >
> >     Are we no longer worried about the scenario where the checkpoint root is $HOME
or /?

The checkpoint root could be set to this but only maliciously.


> On Feb. 10, 2015, 7:12 p.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/executor/test_gc_executor.py, line 180
> > <https://reviews.apache.org/r/30749/diff/9/?file=859053#file859053line180>
> >
> >     s/'fake_root'/FAKE_ROOT

fixed


> On Feb. 10, 2015, 7:12 p.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/executor/test_gc_executor.py, lines 210-211
> > <https://reviews.apache.org/r/30749/diff/9/?file=859053#file859053line210>
> >
> >     Am I missing something or is this a duplicate of the make_task defined above?

totally a dupe, deleted.


> On Feb. 10, 2015, 7:12 p.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/executor/test_gc_executor.py, line 254
> > <https://reviews.apache.org/r/30749/diff/9/?file=859053#file859053line254>
> >
> >     nit: maybe give task_id a default value in make_task instead of having to always
pass in the same placeholder value?

Nah, because in all of these assertions we actually need to know the task id so it wouldn't
make sense to omit from make_task().


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/#review71833
-----------------------------------------------------------


On Feb. 20, 2015, 7:06 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30749/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 7:06 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1025
>     https://issues.apache.org/jira/browse/AURORA-1025
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This makes the GC executor detect checkpoint roots via the PathDetector interface.  This
paves the way to detecting checkpoint roots both from /var/run/thermos and from /var/lib/mesos/**
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 6530f4914736754f92ba192c1a345e4b7e4a5398

>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py b903bcb3630a8a8d50a2008bfae532b2eb947356

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0752d50015b2ff936f079c4a9f2777172dc00a93

>   src/main/python/apache/aurora/executor/gc_executor.py dbec82ffe4e155059f3e6b1aa0e67ec4c52a9611

>   src/main/python/apache/thermos/bin/thermos.py 161bbdbc4de95c82e2b596e77b0eac7b920eae66

>   src/main/python/apache/thermos/monitoring/garbage.py 69bf8e4c2e2e5f85f6b822fbe45f828d61814d7f

>   src/test/python/apache/aurora/executor/bin/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py PRE-CREATION

>   src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py PRE-CREATION

>   src/test/python/apache/aurora/executor/test_gc_executor.py 27dee7fa10a4141ec7e9f4440bde2dd257db1cc6

> 
> Diff: https://reviews.apache.org/r/30749/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/main/python::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message