aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 31241: Pushing transactions up in QuotaManager.
Date Fri, 20 Feb 2015 22:37:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241/#review73328
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
<https://reviews.apache.org/r/31241/#comment119627>

    Would `QuotaStore.Mutable` be sufficient?  That would align with LoD.


- Bill Farner


On Feb. 20, 2015, 10:31 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31241/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 10:31 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing Storage from QuotaManager by pushing transaction layer up the call chain.
> 
> Will no apply cleanly. Diffed against https://reviews.apache.org/r/31235/.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ee7618979ce94631af8aaf7ab3ecb2fbfb33fc38

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
06c8faa9de4d0ac8389dbf07d4e81934b503761b 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4

> 
> Diff: https://reviews.apache.org/r/31241/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message