aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Review Request 31240: Remove render partial job key method.
Date Fri, 20 Feb 2015 22:29:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31240/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Repository: aurora


Description
-------

This continues the refactoring started in https://reviews.apache.org/r/30207/ which will allow
for easier testing and mocking out of the context object. This removes more single caller
methods from the global context object and moves them closer to the callers.


Diffs
-----

  src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4

  src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf

  src/main/python/apache/aurora/client/cli/options.py 36f80aa175beaf8f2dc6b6f962394643313d6405

  src/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904


Diff: https://reviews.apache.org/r/31240/diff/


Testing
-------

./pants test.pytest --no-fast src/test/python/apache/aurora/client::


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message