aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 31137: Update aurora to commons 0.3.3, unflake tests using ThreadedClock
Date Tue, 17 Feb 2015 22:53:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31137/#review72810
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Feb. 17, 2015, 9:59 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31137/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 9:59 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Joe Smith.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> SSIA.  One seemingly incorrect test was removed.  It was unclear to me what behavior
it was testing exactly, and it did not consistently pass.
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 9f7bea9c0dce620c436332e1f4f4c9e3df7f66f5 
>   src/main/python/apache/aurora/executor/gc_executor.py 43b415bc6c5177be24ec036cc32ae7cbd87fc70f

>   src/test/python/apache/aurora/executor/common/test_health_checker.py def249c2509a28f7145380f250f79202b653dc83

>   src/test/python/apache/aurora/executor/test_gc_executor.py b1bbc89a822302d8ea12324eb767631326639ebb

> 
> Diff: https://reviews.apache.org/r/31137/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message