aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
Date Tue, 17 Feb 2015 18:04:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31123/#review72739
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On Feb. 17, 2015, 10 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31123/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 10 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is the first step of many to align our configuration with checkstyle's Google style
config.  There are enough differences that a full switch will touch every file in our code
base, so i'd like to start with targeted changes.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195

>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf

>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45

>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea

>   src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2a9d36ab2c01960dc5384fc3ed90df4e11c0b12a

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5647349854a5e04de749c4d809684a0066d4da06

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764

> 
> Diff: https://reviews.apache.org/r/31123/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message