aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.
Date Fri, 13 Feb 2015 01:40:44 GMT


> On Feb. 13, 2015, 1:17 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 78
> > <https://reviews.apache.org/r/30890/diff/3/?file=862710#file862710line78>
> >
> >     Can you add a getCounterName() abstract method to the VetoGroup enum? That will
make the compiler guarantee that this mapping is complete.

We have discussed this before in https://reviews.apache.org/r/28617/. I still don't feel VetoGroup
should be aware of any counters. I have added a comprehensive test instead that will break
when a new value is added here.


> On Feb. 13, 2015, 1:17 a.m., Kevin Sweeney wrote:
> > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java, line 358
> > <https://reviews.apache.org/r/30890/diff/3/?file=862713#file862713line358>
> >
> >     (Consider moving this test to compile-time with the above approach)

Answered above.


> On Feb. 13, 2015, 1:17 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 181
> > <https://reviews.apache.org/r/30890/diff/3/?file=862711#file862711line181>
> >
> >     Can you use != here since this is an enum?

Pmd does not like it: "Use equals() to compare object references."


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30890/#review72300
-----------------------------------------------------------


On Feb. 13, 2015, 12:58 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30890/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 12:58 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-909
>     https://issues.apache.org/jira/browse/AURORA-909
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Offer filtering for static vetoes. Part 2 of 4: Exposing Veto groups and refactoring
TaskVars.
> 
> Original RB: https://reviews.apache.org/r/28617/
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java f017cdd26ca40138a7e141f21613ed567314c399

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 6a43bcd1719e8aa32fd3fcb7387d0318c3c0b804

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java f06fdaeb92e154d0982bdabed5df93e7bcba9048

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 4e7efb3c1214c3d193afd61f162713490eb8effb

>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 52ee7c1e3742d9315c7e7aaa77677121e1e9288d

> 
> Diff: https://reviews.apache.org/r/30890/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message