aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 30818: Support separate routes for job controller tabs.
Date Wed, 11 Feb 2015 18:58:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30818/#review71999
-----------------------------------------------------------



src/main/resources/scheduler/assets/js/controllers.js
<https://reviews.apache.org/r/30818/#comment117923>

    You should never have to do this with routes in Angular. I think this is a code smell
from mixing dynamic and static parts in the same path part. I'd route to these 'views' of
the job page using anchor tags or query parameters instead.


- David McLaughlin


On Feb. 10, 2015, 6:01 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30818/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 6:01 a.m.)
> 
> 
> Review request for Aurora and David McLaughlin.
> 
> 
> Bugs: AURORA-696
>     https://issues.apache.org/jira/browse/AURORA-696
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Previously navigating between the active/completed/all tabs on the
> job controller page did not alter the browser history. Now it does,
> meaning that you can navigate with the back button as well as link
> directly to a tab.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/job.html 4a00a8863d676f168fbfce9f45ec4bad0244199f

>   src/main/resources/scheduler/assets/js/app.js b66409f628046c67b62c92a75cbeed20c09b4ec1

>   src/main/resources/scheduler/assets/js/controllers.js 092e7d5df2121f45f99f5a788187d52bebb7e5dd

> 
> Diff: https://reviews.apache.org/r/30818/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jsHint
> 
> Verified push state worked in vagrant.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message