aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Review Request 30818: Support separate routes for job controller tabs.
Date Tue, 10 Feb 2015 05:24:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30818/
-----------------------------------------------------------

Review request for Aurora and David McLaughlin.


Bugs: AURORA-696
    https://issues.apache.org/jira/browse/AURORA-696


Repository: aurora


Description
-------

Previously navigating between the active/completed/all tabs on the
job controller page did not alter the browser history. Now it does,
meaning that you can navigate with the back button as well as link
directly to a tab.


Diffs
-----

  src/main/resources/scheduler/assets/job.html 4a00a8863d676f168fbfce9f45ec4bad0244199f 
  src/main/resources/scheduler/assets/js/app.js b66409f628046c67b62c92a75cbeed20c09b4ec1 
  src/main/resources/scheduler/assets/js/controllers.js 092e7d5df2121f45f99f5a788187d52bebb7e5dd


Diff: https://reviews.apache.org/r/30818/diff/


Testing
-------

./gradlew jshint

Verified push state worked in vagrant.


Thanks,

Joshua Cohen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message