aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 30804: Fixing test coverage in startJobUpdate RPC
Date Mon, 09 Feb 2015 22:02:37 GMT


> On Feb. 9, 2015, 9:54 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 2690
> > <https://reviews.apache.org/r/30804/diff/1/?file=858871#file858871line2690>
> >
> >     Consider collapsing these all to one test case related to input validation.

I'd rather not. This goes against general unit testing guideline of "one issue - one test"
and isn't saving much in setup.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30804/#review71707
-----------------------------------------------------------


On Feb. 9, 2015, 7:57 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30804/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 7:57 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The startJobUpdate RPC test coverage got broken in 9fe6d5408d4aed113a239f22fa5c43aa4f9ae338
as all settings tests short-circuited at `isIsService()` validation.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2b5383f3c56927bc42ab47c0a5c7c4b1d41af6dd

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
c6fe218c709c73dbd4c3aeeb94e211ee6cdf9a0d 
> 
> Diff: https://reviews.apache.org/r/30804/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message