aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 30804: Fixing test coverage in startJobUpdate RPC
Date Mon, 09 Feb 2015 19:57:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30804/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Repository: aurora


Description
-------

The startJobUpdate RPC test coverage got broken in 9fe6d5408d4aed113a239f22fa5c43aa4f9ae338
as all settings tests short-circuited at `isIsService()` validation.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2b5383f3c56927bc42ab47c0a5c7c4b1d41af6dd

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java c6fe218c709c73dbd4c3aeeb94e211ee6cdf9a0d


Diff: https://reviews.apache.org/r/30804/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message