aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 30749: Port GC executor to PathDetector interface
Date Mon, 09 Feb 2015 18:44:42 GMT


> On Feb. 8, 2015, 2:20 a.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/executor/gc_executor.py, line 73
> > <https://reviews.apache.org/r/30749/diff/4/?file=853457#file853457line73>
> >
> >     What's the benefit of using a namedtuple here?

As opposed to?  This means we don't have to change every function signature in this file.
 (I suppose on the other hand we get less "type safety" because functions called w/o the correct
number of parameters would at least TypeError.)


> On Feb. 8, 2015, 2:20 a.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/executor/gc_executor.py, line 411
> > <https://reviews.apache.org/r/30749/diff/4/?file=853457#file853457line411>
> >
> >     Shouldn't this log messsage be inside the collector implementation?

The gc executor is on its deathbed -- I propose not changing anything not completely necessary
for its deprecation.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/#review71567
-----------------------------------------------------------


On Feb. 7, 2015, 2:27 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30749/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2015, 2:27 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1025
>     https://issues.apache.org/jira/browse/AURORA-1025
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This makes the GC executor detect checkpoint roots via the PathDetector interface.  This
paves the way to detecting checkpoint roots both from /var/run/thermos and from /var/lib/mesos/**
> 
> 
> Diffs
> -----
> 
>   pants.ini 99648e46ca755c3c8e22d90c7b682107d8dee333 
>   src/main/python/apache/aurora/executor/bin/BUILD 1fa1e9e839bf28093b4e9ded403a761cf4bf5f44

>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py b903bcb3630a8a8d50a2008bfae532b2eb947356

>   src/main/python/apache/aurora/executor/gc_executor.py 43b415bc6c5177be24ec036cc32ae7cbd87fc70f

>   src/main/python/apache/thermos/bin/thermos.py 161bbdbc4de95c82e2b596e77b0eac7b920eae66

>   src/main/python/apache/thermos/monitoring/garbage.py 69bf8e4c2e2e5f85f6b822fbe45f828d61814d7f

>   src/test/python/apache/aurora/executor/test_gc_executor.py b1bbc89a822302d8ea12324eb767631326639ebb

> 
> Diff: https://reviews.apache.org/r/30749/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/main/python::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message