aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 30749: Port GC executor to PathDetector interface
Date Sun, 08 Feb 2015 02:20:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/#review71567
-----------------------------------------------------------



pants.ini
<https://reviews.apache.org/r/30749/#comment117327>

    This not does not appear to be a change related to your work here.



src/main/python/apache/aurora/executor/gc_executor.py
<https://reviews.apache.org/r/30749/#comment117328>

    What's the benefit of using a namedtuple here?



src/main/python/apache/aurora/executor/gc_executor.py
<https://reviews.apache.org/r/30749/#comment117329>

    Shouldn't this log messsage be inside the collector implementation?


- Zameer Manji


On Feb. 6, 2015, 6:27 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30749/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 6:27 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1025
>     https://issues.apache.org/jira/browse/AURORA-1025
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This makes the GC executor detect checkpoint roots via the PathDetector interface.  This
paves the way to detecting checkpoint roots both from /var/run/thermos and from /var/lib/mesos/**
> 
> 
> Diffs
> -----
> 
>   pants.ini 99648e46ca755c3c8e22d90c7b682107d8dee333 
>   src/main/python/apache/aurora/executor/bin/BUILD 1fa1e9e839bf28093b4e9ded403a761cf4bf5f44

>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py b903bcb3630a8a8d50a2008bfae532b2eb947356

>   src/main/python/apache/aurora/executor/gc_executor.py 43b415bc6c5177be24ec036cc32ae7cbd87fc70f

>   src/main/python/apache/thermos/bin/thermos.py 161bbdbc4de95c82e2b596e77b0eac7b920eae66

>   src/main/python/apache/thermos/monitoring/garbage.py 69bf8e4c2e2e5f85f6b822fbe45f828d61814d7f

>   src/test/python/apache/aurora/executor/test_gc_executor.py b1bbc89a822302d8ea12324eb767631326639ebb

> 
> Diff: https://reviews.apache.org/r/30749/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/main/python::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message