aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 27182: Add a test for the thermos resource module
Date Fri, 06 Feb 2015 22:51:02 GMT


> On Feb. 6, 2015, 1:55 p.m., Brian Wickman wrote:
> > Out of curiosity, why this test now?  I sort of see this code on its deathbed as
soon Mesos will have disk enforcement built in.

This test is from October (and just revived). Until we remove this code, it should have test
coverage.


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71510
-----------------------------------------------------------


On Feb. 6, 2015, 2 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27182/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 2 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a test for the thermos resource module
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/monitoring/monitor.py 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef

>   src/test/python/apache/thermos/monitoring/BUILD 33d6bba43aff6d62b2646491f004475c27ed99db

>   src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27182/diff/
> 
> 
> Testing
> -------
> 
> [tw-mbp-jsmith incubator-aurora (yasumoto/thermos_test)]$ ./pants test.pytest ./src/test/python/apache/thermos/monitoring:test_resource
> 
> 21:15:56 00:00 [main]
>                (To run a reporting server: ./pants server)
> 21:15:56 00:00   [bootstrap]
> 21:15:57 00:01   [setup]
> 21:15:57 00:01     [parse]
>                Executing tasks in goals: bootstrap -> imports -> gen -> check-exclusives
-> resolve -> compile -> resources -> test
> 21:15:57 00:01   [bootstrap]
> 21:15:57 00:01     [bootstrap-jvm-tools]
> 21:15:57 00:01   [imports]
> 21:15:57 00:01     [ivy-imports]
> 21:15:57 00:01   [gen]
> 21:15:57 00:01     [thrift]
> 21:15:57 00:01     [scrooge]
> 21:15:57 00:01     [protoc]
> 21:15:57 00:01     [antlr]
> 21:15:57 00:01     [ragel]
> 21:15:57 00:01     [jaxb]
> 21:15:57 00:01     [wire]
> 21:15:57 00:01     [aapt]
> 21:15:57 00:01   [check-exclusives]
> 21:15:57 00:01     [check-exclusives]
> 21:15:57 00:01   [resolve]
> 21:15:57 00:01     [ivy]
> 21:15:57 00:01   [compile]
> 21:15:57 00:01     [jvm]
> 21:15:57 00:01       [jvm-compilers]
> 21:15:57 00:01   [resources]
> 21:15:57 00:01     [prepare]
> 21:15:57 00:01   [test]
> 21:15:57 00:01     [run_prep_command]
> 21:15:57 00:01     [pytest]
> 21:15:57 00:01       [run]
>                      ============== test session starts ===============
>                      platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4
>                      plugins: cov, timeout
>                      collected 5 items 
>                      
>                      src/test/python/apache/thermos/monitoring/test_resource.py .....
>                      
>                      ============ 5 passed in 0.18 seconds ============
>                      
> 21:16:04 00:08     [junit]
> 21:16:04 00:08     [specs]
>                SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message