aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 30586: Fix exception when opening cron urls.
Date Thu, 05 Feb 2015 03:45:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71150
-----------------------------------------------------------



src/test/python/apache/aurora/client/cli/test_cron.py
<https://reviews.apache.org/r/30586/#comment116782>

    The config object in the argument is very complex and difficult to create. With our current
set of test fixtures.


- Zameer Manji


On Feb. 4, 2015, 6:08 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30586/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 6:08 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.
> 
> 
> Bugs: AURORA-1094
>     https://issues.apache.org/jira/browse/AURORA-1094
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix exception when opening cron urls.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428

>   src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a

> 
> Diff: https://reviews.apache.org/r/30586/diff/
> 
> 
> Testing
> -------
> 
> ./pants goal test src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message