aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 30647: Instrument the HealthChecker to export stats.
Date Thu, 05 Feb 2015 02:07:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71127
-----------------------------------------------------------


Master (edcc252) is red with this patch.
  ./build-support/jenkins/build.sh

                     src.test.python.apache.aurora.client.cli.plugins                    
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.quota                      
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.sla                        
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.supdate                    
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.task                       
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.update                     
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.version                    
           .....   SUCCESS
                     src.test.python.apache.aurora.client.config                         
           .....   SUCCESS
                     src.test.python.apache.aurora.client.hooks.hooked_api               
           .....   SUCCESS
                     src.test.python.apache.aurora.client.hooks.non_hooked_api           
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_aurora_job_key            
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_cluster                   
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_cluster_option            
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_clusters                  
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_http_signaler             
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_pex_version               
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_shellify                  
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_transport                 
           .....   SUCCESS
                     src.test.python.apache.aurora.config.test_base                      
           .....   SUCCESS
                     src.test.python.apache.aurora.config.test_constraint_parsing        
           .....   SUCCESS
                     src.test.python.apache.aurora.config.test_loader                    
           .....   SUCCESS
                     src.test.python.apache.aurora.config.test_thrift                    
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.announcer             
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.directory_sandbox     
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.executor_timeout      
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.health_checker        
           .....   FAILURE
                     src.test.python.apache.aurora.executor.common.task_info             
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_base                
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_detector            
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_vars                
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.status_manager               
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.thermos_task_runner          
           .....   SUCCESS
                     src.test.python.apache.thermos.common.test_pathspec                 
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_runner_integration         
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_disk                 
           .....   SUCCESS
                     
FAILURE


               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 5, 2015, 1:46 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 1:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
>     https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530

>   src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984

>   src/test/python/apache/aurora/executor/common/test_health_checker.py def249c2509a28f7145380f250f79202b653dc83

> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message