Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 293AE179CF for ; Fri, 30 Jan 2015 23:13:05 +0000 (UTC) Received: (qmail 71370 invoked by uid 500); 30 Jan 2015 23:13:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 71302 invoked by uid 500); 30 Jan 2015 23:13:05 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 36810 invoked by uid 99); 30 Jan 2015 22:31:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2015 22:31:25 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 30 Jan 2015 22:31:03 +0000 Received: (qmail 33828 invoked by uid 99); 30 Jan 2015 22:31:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2015 22:31:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A7F1E1C0449; Fri, 30 Jan 2015 22:31:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6202514578532535609==" MIME-Version: 1.0 Subject: Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig. From: "Maxim Khutornenko" To: "Bill Farner" , "Joshua Cohen" , "David McLaughlin" Cc: "Aurora" , "Aurora ReviewBot" , "Maxim Khutornenko" Date: Fri, 30 Jan 2015 22:31:04 -0000 Message-ID: <20150130223104.1308.35173@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/30461/ X-Sender: "Maxim Khutornenko" References: <20150130193230.22249.16255@reviews.apache.org> In-Reply-To: <20150130193230.22249.16255@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6202514578532535609== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ ----------------------------------------------------------- (Updated Jan. 30, 2015, 10:31 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Changes ------- Fixing broken test. Bugs: AURORA-1071 https://issues.apache.org/jira/browse/AURORA-1071 Repository: aurora Description ------- - Adding pulse_interval_secs into client UpdateConfig and validating its range - Raising an error in client updater for pulse_interval_secs Diffs (updated) ----- src/main/python/apache/aurora/client/api/updater.py 9f91de625f55514530a4f948d7ecdf7b5614b594 src/main/python/apache/aurora/client/api/updater_util.py 9d2e893a6ecff0fc48c7944575578443d41ced78 src/main/python/apache/aurora/config/schema/base.py e4433d2d47668f59bce169359131284d361bad09 src/test/python/apache/aurora/client/api/test_api.py ff1aff2eac391f219bc7c2483a16e35f916a224c src/test/python/apache/aurora/client/api/test_updater.py dd3f228c5062d388b4393aa4fd5b60a685bdb3a6 src/test/python/apache/aurora/client/api/test_updater_util.py fe3ac49491ca710761632405ac09de0cc0d038a5 Diff: https://reviews.apache.org/r/30461/diff/ Testing (updated) ------- ./pants test.pytest src/test/python/apache/aurora/client:: Thanks, Maxim Khutornenko --===============6202514578532535609==--