Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2259562552284291777=="
MIME-Version: 1.0
Subject: Re: Review Request 29827: End to end tests for docker in aurora
From: "Steve Niemitz" <steve@tellapart.com>
To: "Bill Farner" <wfarner@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Steve Niemitz" <steve@tellapart.com>, "Maxim Khutornenko" <maxim@apache.org>
Date: Wed, 28 Jan 2015 18:12:22 -0000
Message-ID: <20150128181222.25679.19904@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Steve Niemitz" <noreply@reviews.apache.org>
References: <20150128175127.25680.42325@reviews.apache.org>
In-Reply-To: <20150128175127.25680.42325@reviews.apache.org>
Reply-To: "Steve Niemitz" <steve@tellapart.com>

--===============2259562552284291777==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 28, 2015, 5:51 p.m., Maxim Khutornenko wrote:
> > I am getting an error when running e2e tests with this patch:
> > ```
> > + vagrant ssh -c 'cd /vagrant/src/test/sh/org/apache/aurora/e2e && docker build -t http_example .'
> > Sending build context to Docker daemon 
> > FATA[0000] Post http:///var/run/docker.sock/v1.16/build?rm=1&t=http_example: dial unix /var/run/docker.sock: permission denied 
> > Connection to 127.0.0.1 closed.
> > + collect_result
> > + [[ 1 = 0 ]]
> > + echo '!!!'
> > !!!
> > + echo 'FAIL (something returned non-zero)'
> > FAIL (something returned non-zero)
> > + echo ''
> > 
> > ```
> > Anything I am missing?

Nope, good catch.  This was a last minute refactor I made and forgot the sudo here.  I'll submit an update.


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29827/#review70026
-----------------------------------------------------------


On Jan. 27, 2015, 4:58 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29827/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds an end to end test for docker.
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 
> 
> Diff: https://reviews.apache.org/r/29827/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


--===============2259562552284291777==--