Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AF6DA1062E for ; Tue, 27 Jan 2015 19:09:18 +0000 (UTC) Received: (qmail 64592 invoked by uid 500); 27 Jan 2015 19:09:19 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 64546 invoked by uid 500); 27 Jan 2015 19:09:19 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 64535 invoked by uid 99); 27 Jan 2015 19:09:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 19:09:18 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 27 Jan 2015 19:09:17 +0000 Received: (qmail 64331 invoked by uid 99); 27 Jan 2015 19:08:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2015 19:08:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3310E1D70EC; Tue, 27 Jan 2015 19:08:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0951236978896124257==" MIME-Version: 1.0 Subject: Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR From: "Bill Farner" To: "Bill Farner" Cc: "Aurora" , "Jeffrey Schroeder" Date: Tue, 27 Jan 2015 19:08:53 -0000 Message-ID: <20150127190853.25680.87065@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/30249/ X-Sender: "Bill Farner" References: <20150127042738.25680.13459@reviews.apache.org> In-Reply-To: <20150127042738.25680.13459@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0951236978896124257== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/#review69860 ----------------------------------------------------------- Ship it! Ship It! - Bill Farner On Jan. 27, 2015, 4:27 a.m., Jeffrey Schroeder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30249/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:27 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Add CONTRIBUTING.md so github shows a link to it before opening a PR > > > Diffs > ----- > > docs/README.md 4889b3ff208d56e3af34fdd876efaa7719e6504f > docs/contributing.md > > Diff: https://reviews.apache.org/r/30249/diff/ > > > Testing > ------- > > I accidentally opened a github pull request to fix a small documentation tyop previously. Per the [github documentation](https://github.com/blog/1184-contributing-guidelines), if you have CONTRIBUTING.md in the root of the project, it will be shown before a user ever opens a pull request. > > Probably makes sense to prevent people from opening pull requests in the future. Note that this is simply a symlink to docs/contributing.md. > > > Thanks, > > Jeffrey Schroeder > > --===============0951236978896124257==--