Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89276106B4 for ; Tue, 13 Jan 2015 23:11:59 +0000 (UTC) Received: (qmail 52000 invoked by uid 500); 13 Jan 2015 23:12:01 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 51957 invoked by uid 500); 13 Jan 2015 23:12:01 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 51946 invoked by uid 99); 13 Jan 2015 23:12:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 23:12:00 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 13 Jan 2015 23:11:38 +0000 Received: (qmail 51824 invoked by uid 99); 13 Jan 2015 23:11:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 23:11:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7A6251D2CB8; Tue, 13 Jan 2015 23:11:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4834900082479259372==" MIME-Version: 1.0 Subject: Re: Review Request 29866: Upgrade pants to 0.0.27 From: "Joshua Cohen" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Aurora" , "Brian Wickman" , "Joshua Cohen" Date: Tue, 13 Jan 2015 23:11:32 -0000 Message-ID: <20150113231132.23996.90525@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/29866/ X-Sender: "Joshua Cohen" References: <20150113215145.23997.30962@reviews.apache.org> In-Reply-To: <20150113215145.23997.30962@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4834900082479259372== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866/#review67967 ----------------------------------------------------------- build-support/python/make-pycharm-virtualenv We changed to src/test/python:: in the build script, but we're still using src/test/python:all here. Should they be the same? pants What if we have a file in the root like pants.version that's sourced by this and by update-pants-requirements rather than having to keep the version in sync between the two? - Joshua Cohen On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29866/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 9:51 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Ports aurora repo to use pants 0.0.27 using the new pants new command processor. > > > Diffs > ----- > > build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 > build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 > build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 > build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 > build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 > examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd > pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 > src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c > > Diff: https://reviews.apache.org/r/29866/diff/ > > > Testing > ------- > > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Brian Wickman > > --===============4834900082479259372==--