Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2182778119929750463=="
MIME-Version: 1.0
Subject: Re: Review Request 29717: Remove dynamic command hooks and dynamic
 hook policy.
From: "Aurora ReviewBot" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>, "Maxim Khutornenko" <maxim@apache.org>
Cc: "Aurora ReviewBot" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>,
 "Zameer Manji" <zmanji@twopensource.com>
Date: Mon, 12 Jan 2015 22:37:46 -0000
Message-ID: <20150112223746.23996.7188@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aurora ReviewBot" <noreply@reviews.apache.org>
References: <20150112195358.23995.15663@reviews.apache.org>
In-Reply-To: <20150112195358.23995.15663@reviews.apache.org>
Reply-To: "Aurora ReviewBot" <wfarner@apache.org>

--===============2182778119929750463==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29717/#review67720
-----------------------------------------------------------


Master (5ce076b) is red with this patch.
  ./build-support/jenkins/build.sh

  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 88, in run
    rv = self._run_tests([target], stdout, stderr)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 316, in _run_tests
    with self._test_runner(targets, stdout, stderr) as (pex, test_args):
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 295, in _test_runner
    builder = chroot.dump()
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py", line 191, in dump
    conn_timeout=self._conn_timeout)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py", line 100, in resolve_multi
    platform=platform)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 110, in resolve
    new_requirements.update(requires(highest_package, requirement))
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 84, in requires
    raise Untranslateable('Package %s is not translateable.' % package)
Untranslateable: Package WheelPackage(u'https://pypi.python.org/packages/2.7/r/requests/requests-2.3.0-py2.py3-none-any.whl#md5=f2d850fd48fc10a93aa03d69b87b96b4') is not translateable.


Usage: 
  pants build (options) [spec] (build args)
  pants build (options) [spec]... -- (build args)

Options:
  --version             show program's version number and exit
  --no-pantsrc          Specifies that pantsrc files should be ignored.
  --log-exit            Log an exit message on success or failure.
  -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
                        Number of seconds to wait for http connections.
  -i INTERPRETERS, --interpreter=INTERPRETERS
                        Constrain what Python interpreters to use.  Uses
                        Requirement format from pkg_resources, e.g.
                        'CPython>=2.6,<3' or 'PyPy'. By default, no
                        constraints are used.  Multiple constraints may be
                        added.  They will be ORed together.
  -v, --verbose         Show verbose output.
  -f, --fast            Run tests in a single chroot.

Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 12, 2015, 7:53 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29717/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 7:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch removes the dynamic hooks functionality and dynamic hook policy mechanism from the client. As far as I can tell they are currently unused and add a lot of complexity to the client.
> 
> 
> Diffs
> -----
> 
>   docs/design/command-hooks.md cc56218625edfd1b255f1ca18ae91c32e2dcccef 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/command_hooks.py aa850bf941bede1d3bd8aae4811cb094ba77965f 
>   src/test/python/apache/aurora/client/cli/AuroraHooks e27fcc81d6092b3b42f9a2948e3955d8f6963a14 
>   src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 9a221591250f4d0d3b1b75f90b8b4cf8f95ee4b9 
>   src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 5dc5907b9ae87632f91084e43be319c6f1b4f437 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 
> 
> Diff: https://reviews.apache.org/r/29717/diff/
> 
> 
> Testing
> -------
> 
> ./pants build --timeout=60 src/test/python/apache/aurora/client/cli:command_hooks -vxs
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


--===============2182778119929750463==--