Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5272F1737A for ; Fri, 9 Jan 2015 01:03:17 +0000 (UTC) Received: (qmail 2612 invoked by uid 500); 9 Jan 2015 01:03:18 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 2570 invoked by uid 500); 9 Jan 2015 01:03:18 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 2554 invoked by uid 99); 9 Jan 2015 01:03:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jan 2015 01:03:17 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 09 Jan 2015 01:02:55 +0000 Received: (qmail 1876 invoked by uid 99); 9 Jan 2015 01:02:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jan 2015 01:02:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AD5091D1CC8; Fri, 9 Jan 2015 01:02:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4501132945535666244==" MIME-Version: 1.0 Subject: Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs. From: "Joshua Cohen" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Aurora ReviewBot" , "Aurora" , "Joshua Cohen" Date: Fri, 09 Jan 2015 01:02:50 -0000 Message-ID: <20150109010250.26559.10306@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/29734/ X-Sender: "Joshua Cohen" References: <20150109004159.26559.56912@reviews.apache.org> In-Reply-To: <20150109004159.26559.56912@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4501132945535666244== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734/ ----------------------------------------------------------- (Updated Jan. 9, 2015, 1:02 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes ------- -wfarner, +ksweeney so we can ship this and quiet the noise from failed reviewbot builds. Repository: aurora Description ------- Fix reviewbot to skip reviews that have no diffs. We're seeing [failures](https://builds.apache.org/job/AuroraBot/724/console) of the AuroraBot job for a [review](https://reviews.apache.org/r/28943/) that has no diffs. This should fix those cases. Diffs ----- build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing ------- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen --===============4501132945535666244==--