Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDACBCE9D for ; Wed, 7 Jan 2015 21:57:39 +0000 (UTC) Received: (qmail 76916 invoked by uid 500); 7 Jan 2015 21:57:41 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 76875 invoked by uid 500); 7 Jan 2015 21:57:40 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 76860 invoked by uid 99); 7 Jan 2015 21:57:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2015 21:57:39 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 07 Jan 2015 21:57:38 +0000 Received: (qmail 75455 invoked by uid 99); 7 Jan 2015 21:57:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2015 21:57:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D90341CCAEB; Wed, 7 Jan 2015 21:57:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2718610170737582612==" MIME-Version: 1.0 Subject: Re: Review Request 29216: Removing client v1 code. From: "Aurora ReviewBot" To: "Zameer Manji" , "Kevin Sweeney" Cc: "Aurora ReviewBot" , "Aurora" , "Maxim Khutornenko" Date: Wed, 07 Jan 2015 21:57:15 -0000 Message-ID: <20150107215715.26560.19223@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/29216/ X-Sender: "Aurora ReviewBot" References: <20150107214244.26560.81427@reviews.apache.org> In-Reply-To: <20150107214244.26560.81427@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2718610170737582612== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29216/#review67105 ----------------------------------------------------------- This patch does not apply cleanly on master (5d8424c), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 7, 2015, 9:42 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29216/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 9:42 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-775 > https://issues.apache.org/jira/browse/AURORA-775 > > > Repository: aurora > > > Description > ------- > > Despite the diff size, the changes are very limited in scope. The majority of green/yellow is consolidating admin-related code under /apache/aurora/admin. The rest is removals and renamings to get rid of "v2". > > This diff has minor overlaps with https://reviews.apache.org/r/28971 in vagrant and target renaming parts. > > > Diffs > ----- > > examples/vagrant/aurorabuild.sh b7ea41719a8f41bb23d0254e732926d89399c77c > src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040 > src/main/python/apache/aurora/client/BUILD 1a91ff64ce2654b16f8932d445626200c2cb5b00 > src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5 > src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62 > src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97 > src/main/python/apache/aurora/client/base.py 258c1fa87645ec48854198529392c84ae08c93be > src/main/python/apache/aurora/client/bin/BUILD a69807ff91fde2bba7874f46f6c82895bdac19ff > src/main/python/apache/aurora/client/bin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/main/python/apache/aurora/client/bin/aurora_admin.py 136cf601f0cc137f5111f1ddec5fd823375626b6 > src/main/python/apache/aurora/client/bin/aurora_client.py 4999265af358d06d236e819bd600426f4574742c > src/main/python/apache/aurora/client/cli/BUILD 8bcaccc08032d853a602c49a7f3cbf1b5f94a2f4 > src/main/python/apache/aurora/client/cli/bridge.py 227abf8e21186dd079bc6ce6ff0408a973ad3ab8 > src/main/python/apache/aurora/client/cli/context.py f062afc8de1769f6796fc307107c61a59e9366c5 > src/main/python/apache/aurora/client/cli/jobs.py 8bdb7f488f68b10b767ced627e55e57698e4f5f2 > src/main/python/apache/aurora/client/cli/update.py d1d0b2946c0513381345d90fabe22c1b7c6b8ca9 > src/main/python/apache/aurora/client/commands/BUILD 33cd91f02e3b323ffd55e3f1841ecb15cb003ae6 > src/main/python/apache/aurora/client/commands/__init__.py > src/main/python/apache/aurora/client/commands/admin.py b7cbba02860af576d9d09e54641d261d7e32c56e > src/main/python/apache/aurora/client/commands/core.py cbaa67a78533fedf679eb993c9deb0f09b705616 > src/main/python/apache/aurora/client/commands/help.py f79e9718fa9fd8f69331d60e95988f89105089f4 > src/main/python/apache/aurora/client/commands/maintenance.py 5321eb6e8d8a15a5e2115e3664d5f12990b67617 > src/main/python/apache/aurora/client/commands/run.py 6844ac3eb977f5debfad003eb9e6590d3bb2022e > src/main/python/apache/aurora/client/commands/ssh.py ab6832ccb53335ed044b2708abfdac041253f676 > src/main/python/apache/aurora/client/options.py f43aced0131cea3adac018d8abcd938ad45af35f > src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2 > src/test/python/apache/aurora/client/BUILD e40c7a6cb0e86d0436aff18341a5fc8f3bf9faf8 > src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75 > src/test/python/apache/aurora/client/api/api_util.py > src/test/python/apache/aurora/client/api/test_api.py 7390d1c4efc5f7b2ec140590de4a293958f73a87 > src/test/python/apache/aurora/client/api/test_disambiguator.py 72e98d266e96104552e6891dad737701a04f29c1 > src/test/python/apache/aurora/client/api/test_job_monitor.py 1e7a8793e821da3ed53e0ea2b073ea434993a2c6 > src/test/python/apache/aurora/client/api/test_quota_check.py 2c9bef1e8b4a9e65cbb7af7c07dc4fc23b224d16 > src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1 > src/test/python/apache/aurora/client/cli/BUILD 4b5817e667281525295730664f96dedeb3e02779 > src/test/python/apache/aurora/client/cli/test_bridge.py 6c40bf74677aa6306657dd30016cc380ac20f989 > src/test/python/apache/aurora/client/cli/test_cron.py c748212febf5867f5f7cc54e34bf91a8890d9999 > src/test/python/apache/aurora/client/cli/util.py 6dba1855f8951d38882c0d5b01a5a609b774d00f > src/test/python/apache/aurora/client/commands/BUILD 86ab65e40536a28bddbf8efc9148111ba1518465 > src/test/python/apache/aurora/client/commands/__init__.py > src/test/python/apache/aurora/client/commands/test_admin.py b093682d3ac22f00eb88e98dec4c33dca84fb574 > src/test/python/apache/aurora/client/commands/test_admin_sla.py ec558f8843dc7e9b18b7d292e0869c9e653dd103 > src/test/python/apache/aurora/client/commands/test_cancel_update.py e827b386323906ba827c8f1ebc7745d2303ddc23 > src/test/python/apache/aurora/client/commands/test_create.py 2a61d6e81ba021d9eedb609c43bd4e4a0fbe7943 > src/test/python/apache/aurora/client/commands/test_diff.py 8e346ed3e6b8c91a7882029cd0734bd55165c479 > src/test/python/apache/aurora/client/commands/test_hooks.py de1781eecf28c846404849c9cb3b87372fd93276 > src/test/python/apache/aurora/client/commands/test_kill.py 52732eaf6cec5fa37fd8596c3dbdc31e217dc116 > src/test/python/apache/aurora/client/commands/test_listjobs.py a7cb98f8638aac1372419cd2db8c1ce610fdf92f > src/test/python/apache/aurora/client/commands/test_maintenance.py 20eecc03504277a2178295510efe0db5464fcfde > src/test/python/apache/aurora/client/commands/test_restart.py 3789f3bd9ea2753070c966e0b755ab2168f7dd05 > src/test/python/apache/aurora/client/commands/test_run.py 528c3e9d93cb180eda9b2a7e0163737b95b9226e > src/test/python/apache/aurora/client/commands/test_ssh.py 5af91336da2fc4eac268a6e351863b6f5403d060 > src/test/python/apache/aurora/client/commands/test_status.py 003af25b99ef3ec4b087df4c37e7626873cafbb8 > src/test/python/apache/aurora/client/commands/test_update.py 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 > src/test/python/apache/aurora/client/commands/test_version.py cb0f4103fbcff93b506c6faf2b229ec9829f7caa > src/test/python/apache/aurora/client/commands/util.py 0d93e76878613073812e96dcc98b95b6b0beafbe > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 2a436b40ebb2e13f88c1cabc610e41e0eea95dda > > Diff: https://reviews.apache.org/r/29216/diff/ > > > Testing > ------- > > ./pants src/test/python:all > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Maxim Khutornenko > > --===============2718610170737582612==--