Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============6647630252884270051=="
MIME-Version: 1.0
Subject: Re: Review Request 29464: Add option to override local scheduler
 address published into ZooKeeper
From: "Bill Farner" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>, "Kevin Sweeney" <kevints@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Steve Niemitz" <steve@tellapart.com>
Date: Tue, 06 Jan 2015 21:49:18 -0000
Message-ID: <20150106214918.26559.68297@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20141229203607.31225.57961@reviews.apache.org>
In-Reply-To: <20141229203607.31225.57961@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>

--===============6647630252884270051==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 29, 2014, 8:36 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java, line 21
> > <https://reviews.apache.org/r/29464/diff/1/?file=802787#file802787line21>
> >
> >     Convention is to place CmdLine Args in Guice Modules (to separate wiring from implementation). Also, this value will need to be plumbed into the mesos Log somehow.
> 
> Steve Niemitz wrote:
>     Ok cool, I can make that change.
> 
> Steve Niemitz wrote:
>     Also can you explain more what you mean by "plumbed into the mesos Log somehow"?
> 
> Kevin Sweeney wrote:
>     When running multiple schedulers they need to communicate with each other to coordinate writes to the Mesos replicated log. They do this by advertising their IP address in zookeeper. Part of that: the scheduler IP (actually libprocess PID, which contains the scheduler IP) is written to a znode under (the value of -native_log_zk_group_path).
> 
> Steve Niemitz wrote:
>     Ah ok I understand now.  The intention of this patch was more for ease of use for external clients (eg I'm not able to resolve EC2 internal IPs).  Do you think this needs to change as well?  I'm hesitant to change it since I haven't seen any issues with it as-is.

I think you're okay as-is, since it's probably rare for the schedulers in a quorum to have a network barrier.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review66297
-----------------------------------------------------------


On Jan. 5, 2015, 6:47 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29464/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 6:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I've added a new flag for the aurora scheduler, -hostname which can override the scheduler server address published into ZK.
> 
> This is useful for cases such as running the scheduler in EC2, where the autodetected local address is actual an interal IP and not the public address of the machine.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 2c449a491bc5a8ac858ea6487e4cef0591f36f66 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 360e161b6c3f6fd412c7e8de7f1b9a3af109593c 
>   src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java cf173850635572c0df38bdd5cb14de8ce2016bf7 
>   src/main/python/apache/aurora/executor/common/announcer.py 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 
>   src/main/python/apache/thermos/bin/thermos_runner.py 647de2771f301b17de33d8b45198c211d2e84367 
>   src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 
>   src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java c3bf5ea4cbeaad03e187f84215b86531d55c25b3 
>   src/test/python/apache/aurora/executor/common/test_announcer.py e329a90b8fba43611f5120e2a5ee82220dbe2a91 
> 
> Diff: https://reviews.apache.org/r/29464/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


--===============6647630252884270051==--