Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9CC1410617 for ; Mon, 5 Jan 2015 18:48:08 +0000 (UTC) Received: (qmail 42565 invoked by uid 500); 5 Jan 2015 18:48:09 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 42522 invoked by uid 500); 5 Jan 2015 18:48:09 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 42497 invoked by uid 99); 5 Jan 2015 18:48:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2015 18:48:05 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 05 Jan 2015 18:48:04 +0000 Received: (qmail 41909 invoked by uid 99); 5 Jan 2015 18:47:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2015 18:47:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CAD2B1CABF7; Mon, 5 Jan 2015 18:47:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4896998125066558605==" MIME-Version: 1.0 Subject: Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper From: "Steve Niemitz" To: "Bill Farner" , "Kevin Sweeney" Cc: "Joshua Cohen" , "Aurora" , "Stephan Erb" , "Steve Niemitz" Date: Mon, 05 Jan 2015 18:47:41 -0000 Message-ID: <20150105184741.26559.22418@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Steve Niemitz" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/29464/ X-Sender: "Steve Niemitz" References: <20141231183245.31225.31961@reviews.apache.org> In-Reply-To: <20141231183245.31225.31961@reviews.apache.org> Reply-To: "Steve Niemitz" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4896998125066558605== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/ ----------------------------------------------------------- (Updated Jan. 5, 2015, 6:47 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes ------- Adding reviewers -wfarner Repository: aurora Description ------- I've added a new flag for the aurora scheduler, -hostname which can override the scheduler server address published into ZK. This is useful for cases such as running the scheduler in EC2, where the autodetected local address is actual an interal IP and not the public address of the machine. Diffs ----- api/src/main/thrift/org/apache/thermos/thermos_internal.thrift 2c449a491bc5a8ac858ea6487e4cef0591f36f66 src/main/java/org/apache/aurora/scheduler/app/AppModule.java 360e161b6c3f6fd412c7e8de7f1b9a3af109593c src/main/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverrides.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java cf173850635572c0df38bdd5cb14de8ce2016bf7 src/main/python/apache/aurora/executor/common/announcer.py 9e5bdc3885e76d8d03aa946caac9fdec7e1e9186 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/bin/thermos_runner.py 647de2771f301b17de33d8b45198c211d2e84367 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/test/java/org/apache/aurora/scheduler/app/LocalServiceRegistryWithOverridesTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java c3bf5ea4cbeaad03e187f84215b86531d55c25b3 src/test/python/apache/aurora/executor/common/test_announcer.py e329a90b8fba43611f5120e2a5ee82220dbe2a91 Diff: https://reviews.apache.org/r/29464/diff/ Testing ------- Thanks, Steve Niemitz --===============4896998125066558605==--