aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.
Date Fri, 30 Jan 2015 22:00:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review70427
-----------------------------------------------------------


Master (c739122) is red with this patch.
  ./build-support/jenkins/build.sh

                                 raise AssertionError('Expected call: %s\nNot called'
% (expected,))
                         
                             if self.call_args != (args, kwargs):
                                 msg = self._format_mock_failure_message(args, kwargs)
                     >           raise AssertionError(msg)
                     E           AssertionError: Expected call: startJobUpdate(JobUpdateRequest(instanceCount=5,
settings=JobUpdateSettings(blockIfNoPulsesAfterMs=None, updateOnlyTheseInstances=None, maxPerInstanceFailures=2,
maxWaitToInstanceRunningMs=50000, waitForBatchCompletion=False, rollbackOnFailure=True, minWaitInInstanceRunningMs=50000,
updateGroupSize=1, maxFailedInstances=1), taskConfig=TaskConfig(isService=None, priority=None,
taskLinks=None, container=Container(docker=None, mesos=MesosContainer()), executorConfig=None,
metadata=None, requestedPorts=None, jobName=None, environment=None, ramMb=None, job=None,
production=None, diskMb=None, owner=None, maxTaskFailures=None, contactEmail=None, numCpus=None,
constraints=None)))
                     E           Actual call: startJobUpdate(JobUpdateRequest(instanceCount=5,
settings=JobUpdateSettings(blockIfNoPulsesAfterMs=0, updateOnlyTheseInstances=None, maxPerInstanceFailures=2,
maxWaitToInstanceRunningMs=50000, waitForBatchCompletion=False, rollbackOnFailure=True, minWaitInInstanceRunningMs=50000,
updateGroupSize=1, maxFailedInstances=1), taskConfig=TaskConfig(isService=None, priority=None,
taskLinks=None, container=Container(docker=None, mesos=MesosContainer()), executorConfig=None,
metadata=None, requestedPorts=None, jobName=None, environment=None, ramMb=None, job=None,
production=None, diskMb=None, owner=None, maxTaskFailures=None, contactEmail=None, numCpus=None,
constraints=None)))
                     
                     /tmp/user/2395/tmph5gM1a/.deps/mock-1.0.1-py2-none-any.whl/mock.py:835:
AssertionError
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.api.api.xml

                     ====== 1 failed, 10 passed in 0.74 seconds =======
                     src.test.python.apache.aurora.admin.admin                           
           .....   SUCCESS
                     src.test.python.apache.aurora.admin.host_maintenance                
           .....   SUCCESS
                     src.test.python.apache.aurora.admin.maintenance                     
           .....   SUCCESS
                     src.test.python.apache.aurora.client.api.api                        
           .....   FAILURE
                     src.test.python.apache.aurora.client.api.updater                    
           .....   SUCCESS
                     src.test.python.apache.aurora.client.base                           
           .....   SUCCESS
                     src.test.python.apache.aurora.client.binding_helper                 
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.config                     
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.cron                       
           .....   SUCCESS
                     src.test.python.apache.aurora.client.cli.sla                        
           .....   SUCCESS
                     src.test.python.apache.aurora.client.config                         
           .....   SUCCESS
                     src.test.python.apache.aurora.client.hooks.non_hooked_api           
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_aurora_job_key            
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_cluster                   
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_cluster_option            
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_clusters                  
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_http_signaler             
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_pex_version               
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_shellify                  
           .....   SUCCESS
                     src.test.python.apache.aurora.common.test_transport                 
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.task_info             
           .....   SUCCESS
                     src.test.python.apache.thermos.common.test_pathspec                 
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_runner_integration         
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_disk                 
           .....   SUCCESS
                     
FAILURE


               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 30, 2015, 7:32 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30461/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 7:32 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
> 
> 
> Bugs: AURORA-1071
>     https://issues.apache.org/jira/browse/AURORA-1071
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Adding pulse_interval_secs into client UpdateConfig and validating its range
> - Raising an error in client updater for pulse_interval_secs
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/updater.py 9f91de625f55514530a4f948d7ecdf7b5614b594

>   src/main/python/apache/aurora/client/api/updater_util.py 9d2e893a6ecff0fc48c7944575578443d41ced78

>   src/main/python/apache/aurora/config/schema/base.py e4433d2d47668f59bce169359131284d361bad09

>   src/test/python/apache/aurora/client/api/test_updater.py dd3f228c5062d388b4393aa4fd5b60a685bdb3a6

>   src/test/python/apache/aurora/client/api/test_updater_util.py fe3ac49491ca710761632405ac09de0cc0d038a5

> 
> Diff: https://reviews.apache.org/r/30461/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python/apache/aurora/client/api:updater
> ./pants test.pytest src/test/python/apache/aurora/client/api:updater_util
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message