aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 30446: Fix compile errors under Java 8.
Date Fri, 30 Jan 2015 16:56:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/#review70374
-----------------------------------------------------------


"I'm not in love with this fix, but the alternative is to declare these methods as throwing
Exception which propagates out pretty widely." - that happens to be exactly what we do in
java unit tests. No matter the type, it will still surface in the run log.

- Maxim Khutornenko


On Jan. 30, 2015, 7:04 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30446/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 7:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix compile errors under Java 8.
> 
> I think this is just caused by the Java 8 compiler having better type inference than
Java 7?
> 
> I'm not in love with this fix, but the alternative is to declare these methods as throwing
`Exception` which propagates out pretty widely. Happy to go that route if folks prefer, but
figured I'd start with the more tactical fix.
> 
> 
> Diffs
> -----
> 
>   src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a

> 
> Diff: https://reviews.apache.org/r/30446/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message