aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Review Request 30433: Prevent multiple active job updates from being inserted into storage.
Date Fri, 30 Jan 2015 00:21:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30433/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1023
    https://issues.apache.org/jira/browse/AURORA-1023


Repository: aurora


Description
-------

This adds a guard before an update is saved to make sure we don't already have an active update
for the given job.  This was an implied invariant due to the relationship between the locks
table and job updates table, but that relationship can be compromised by outside user action.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java a992938d4e12b20f81608be6bbdc24c0a211c3fd

  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4c827b183a87b4d97774edbfaa960bd1c3de72a5


Diff: https://reviews.apache.org/r/30433/diff/


Testing
-------


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message