aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Niemitz" <st...@tellapart.com>
Subject Re: Review Request 29827: End to end tests for docker in aurora
Date Wed, 28 Jan 2015 18:12:22 GMT


> On Jan. 28, 2015, 5:51 p.m., Maxim Khutornenko wrote:
> > I am getting an error when running e2e tests with this patch:
> > ```
> > + vagrant ssh -c 'cd /vagrant/src/test/sh/org/apache/aurora/e2e && docker
build -t http_example .'
> > Sending build context to Docker daemon 
> > FATA[0000] Post http:///var/run/docker.sock/v1.16/build?rm=1&t=http_example:
dial unix /var/run/docker.sock: permission denied 
> > Connection to 127.0.0.1 closed.
> > + collect_result
> > + [[ 1 = 0 ]]
> > + echo '!!!'
> > !!!
> > + echo 'FAIL (something returned non-zero)'
> > FAIL (something returned non-zero)
> > + echo ''
> > 
> > ```
> > Anything I am missing?

Nope, good catch.  This was a last minute refactor I made and forgot the sudo here.  I'll
submit an update.


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29827/#review70026
-----------------------------------------------------------


On Jan. 27, 2015, 4:58 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29827/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds an end to end test for docker.
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/Dockerfile PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415

> 
> Diff: https://reviews.apache.org/r/29827/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message