aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Schroeder" <jeffschroe...@computer.org>
Subject Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR
Date Tue, 27 Jan 2015 04:27:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30249/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 4:27 a.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Updated per review comments. Moved docs/contributing.md --> CONTRIBUTING.md per the github
documentation.


Repository: aurora


Description
-------

Add CONTRIBUTING.md so github shows a link to it before opening a PR


Diffs (updated)
-----

  docs/README.md 4889b3ff208d56e3af34fdd876efaa7719e6504f 
  docs/contributing.md  

Diff: https://reviews.apache.org/r/30249/diff/


Testing
-------

I accidentally opened a github pull request to fix a small documentation tyop previously.
Per the [github documentation](https://github.com/blog/1184-contributing-guidelines), if you
have CONTRIBUTING.md in the root of the project, it will be shown before a user ever opens
a pull request.

Probably makes sense to prevent people from opening pull requests in the future. Note that
this is simply a symlink to docs/contributing.md.


Thanks,

Jeffrey Schroeder


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message