aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
Date Tue, 27 Jan 2015 01:33:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review69724
-----------------------------------------------------------


Master (0cb40d1) is red with this patch.
  ./build-support/jenkins/build.sh

  File "build/bdist.linux-x86_64/egg/pkg_resources.py", line 830, in obtain
    for item in search_path:
  File "build/bdist.linux-x86_64/egg/setuptools/dist.py", line 314, in fetch_build_egg
  File "build/bdist.linux-x86_64/egg/setuptools/command/easy_install.py", line 581, in easy_install
    
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 591, in fetch_distribution
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 428, in find_packages
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 769, in scan_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 326, in process_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 405, in process_index
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 769, in scan_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 305, in process_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 703, in open_url
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 902, in _socket_timeout
  File "build/bdist.linux-x86_64/egg/setuptools/package_index.py", line 1015, in open_with_auth
  File "/usr/lib/python2.7/urllib2.py", line 404, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 422, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1214, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1187, in do_open
    r = h.getresponse(buffering=True)
  File "/usr/lib/python2.7/httplib.py", line 1045, in getresponse
    response.begin()
  File "/usr/lib/python2.7/httplib.py", line 409, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python2.7/httplib.py", line 365, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/usr/lib/python2.7/socket.py", line 476, in readline
    data = self._sock.recv(self._rbufsize)
socket.timeout: timed out


               FAILURE
Exception message: Package SourcePackage('file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python/eggs/protobuf-3.0.0-alpha-1.tar.gz')
is not translateable.




I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 27, 2015, 1:08 a.m., Florian Pfeiffer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30010/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 1:08 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-184
>     https://issues.apache.org/jira/browse/AURORA-184
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
> 
> This is the first step for AURORA-184, that removes the default host&rack limit constraints.
> The second step that's still missing would be to add s.th. like "--default-constraints"
as start parameter to the scheduler. 
> 
> AURORA-174 could probably be closed with this?(since the rack limit constraint can be
configured in the .aurora file)
> 
> I can't really estimate the effect of my changes in StorageBackfillTest&SchedulerThriftInterfaceTest,
please have a closer look at the changes I did there.
> 
> Since this is also my first code submit, comments about codestyle&other bad habbits
are very appreciated.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 5dfbcf1f6de716502a28f7da33a095968eb8420e

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
92ba45033ada8114349c435316c9681395aea706 
> 
> Diff: https://reviews.apache.org/r/30010/diff/
> 
> 
> Testing
> -------
> 
> Added test for ConfigurationManager.hasName 
> Added test testNoHostAndRackConstraintsAdded, that checks if the constraints are present
> Tested on vagrant devcluster to see if constraints are also gone in "real life"
> 
> 
> Thanks,
> 
> Florian Pfeiffer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message