aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 30178: Avoid performing RPC authentication while holding the write lock.
Date Mon, 26 Jan 2015 23:42:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30178/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 11:42 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
-------

People -= Steve
People += Maxim


Bugs: AURORA-1045
    https://issues.apache.org/jira/browse/AURORA-1045


Repository: aurora


Description
-------

The primary metric for success with this patch is to never interact with `sessionValidator`
within a `storage.write` closure.

This had two outcomes:
1. collapsing update-related RPC implementations for better DRY behavior
2. refactoring `killTasks`

(2) has a behavioral change, though i think it's the correct behavior.  For example, before
this patch you could successfully kill all `PENDING` tasks, as long as you happened to own
those tasks.  The new behavior denies these requests for non-admin users regardless of the
result of the query.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ac92959f34a3b0962d6aa018dc82a5ac72ea1b34

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ad9126c32893080e128d086ea3bfd7ad23d27b89


Diff: https://reviews.apache.org/r/30178/diff/


Testing
-------


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message