aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 30285: Add Protobufs anonymous class back to untested classes list.
Date Mon, 26 Jan 2015 21:05:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30285/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 9:05 p.m.)


Review request for Aurora and Zameer Manji.


Repository: aurora


Description (updated)
-------

This broke as a result of me reverting a change done in https://reviews.apache.org/r/28920/
when resolving merge conflicts.  Prior to that patch, a call to `LOG.fine` was guarded by
an if statement, which was removed.  I reverted that since the purpose of the guard was performance-related
(protobuf's `toString()` function can be very expensive).  For some unknown reason my local
builds continued to pass after this change, despite failing in jenkins.  This was made worse
by https://issues.apache.org/jira/browse/AURORA-1060, which caused review bot to fail at a
point before this check was done.


Diffs
-----

  config/legacy_untested_classes.txt 3429e35376cf71863dcc63c9c667aa70b0ec6b22 

Diff: https://reviews.apache.org/r/30285/diff/


Testing
-------


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message