aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR
Date Sun, 25 Jan 2015 05:25:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30249/#review69556
-----------------------------------------------------------

Ship it!


You'll need a ship it from a committer who will be on the hook to merge this, but thanks for
adding this. I think it'll help reduce the back and forth when we get pull requests on GH!

- Joshua Cohen


On Jan. 24, 2015, 9:53 p.m., Jeffrey Schroeder wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30249/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 9:53 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add CONTRIBUTING.md so github shows a link to it before opening a PR
> 
> 
> Diffs
> -----
> 
>   CONTRIBUTING.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30249/diff/
> 
> 
> Testing
> -------
> 
> I accidentally opened a github pull request to fix a small documentation tyop previously.
Per the [github documentation](https://github.com/blog/1184-contributing-guidelines), if you
have CONTRIBUTING.md in the root of the project, it will be shown before a user ever opens
a pull request.
> 
> Probably makes sense to prevent people from opening pull requests in the future. Note
that this is simply a symlink to docs/contributing.md.
> 
> 
> Thanks,
> 
> Jeffrey Schroeder
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message