aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 30207: Simplify AuroraCommandContext
Date Fri, 23 Jan 2015 21:46:02 GMT


> On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote:
> > I am not convinced there is enough value in this diff to risk possible regression.
Besides, the majority of what this diff touches will die out along with the client updater.
> 
> Zameer Manji wrote:
>     Is there an ETA for the destruction of the client updater?

Any time we feel ready to drop "beta" from scheduler updater.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30207/#review69458
-----------------------------------------------------------


On Jan. 23, 2015, 3:32 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30207/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 3:32 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The AuroraCommandContext class is used in multiple commands and contains common code
for all of them. However some portions are only used by one command. This patch takes some
of those portions and moves them to the command that requires that functionality.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4

>   src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf

>   src/main/python/apache/aurora/client/cli/update.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_supdate.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_update.py 8b7d11202b35deb09a0000248cfe0a96458fb70c

> 
> Diff: https://reviews.apache.org/r/30207/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message