aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 30225: Modifying update controller to support heartbeats.
Date Fri, 23 Jan 2015 20:37:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.


Bugs: AURORA-1010
    https://issues.apache.org/jira/browse/AURORA-1010


Repository: aurora


Description
-------

Added pulsing support into the JobUpdateController. The qualified coordinated updates get
blocked until a pulse arrives. An update then becomes active and proceeds until `blockIfNoPulsesAfterMs`
expires or the update reaches a terminal state (whichever comes first).

Not particularly happy with plumbing through OneWayJobUpdater but the alternative is a state
machine change, which is much hairier and will require more changes in the JobUpdaterController.
Going with the minimal diff here.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java d3b30d48b76d8d7c64cda006a34f7ed3296526f2

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java a992938d4e12b20f81608be6bbdc24c0a211c3fd

  src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 27a5b9026f5ac3b3bdeb32813b10435bc3dab173

  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4c827b183a87b4d97774edbfaa960bd1c3de72a5

  src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987


Diff: https://reviews.apache.org/r/30225/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message