aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Review Request 30207: Simplify AuroraCommandContext
Date Fri, 23 Jan 2015 03:32:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30207/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Repository: aurora


Description
-------

The AuroraCommandContext class is used in multiple commands and contains common code for all
of them. However some portions are only used by one command. This patch takes some of those
portions and moves them to the command that requires that functionality.


Diffs
-----

  src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4

  src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf

  src/main/python/apache/aurora/client/cli/update.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_supdate.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/test_update.py 8b7d11202b35deb09a0000248cfe0a96458fb70c


Diff: https://reviews.apache.org/r/30207/diff/


Testing
-------

./pants test.pytest --no-fast src/test/python/apache/aurora/client::


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message