aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 29984: Minor clean up to mock usage in resource manager integration tests.
Date Wed, 21 Jan 2015 00:52:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68828
-----------------------------------------------------------


*ping*

- Joshua Cohen


On Jan. 16, 2015, 9:45 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29984/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 9:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Minor clean up to mock usage in resource manager integration tests.
> 
> We didn't need to wrap the mock disk collector in a lambda, just rather than asserting
on the mock class, we instead needed to assert on its return value (the instance).
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
bb3045700c2870329e175db44873dcb990226c7a 
> 
> Diff: https://reviews.apache.org/r/29984/diff/
> 
> 
> Testing
> -------
> 
> ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message