aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Pfeiffer" <apacherevi...@x8s.de>
Subject Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
Date Sun, 18 Jan 2015 04:05:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

[AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

This is the first step for AURORA-184, that removes the default host&rack limit constraints.
The second step that's still missing would be to add s.th. like "--default-constraints" as
start parameter to the scheduler. 

AURORA-174 could probably be closed with this?(since the rack limit constraint can be configured
in the .aurora file)

I can't really estimate the effect of my changes in StorageBackfillTest&SchedulerThriftInterfaceTest,
please have a closer look at the changes I did there.

Since this is also my first code submit, comments about codestyle&other bad habbits are
very appreciated.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59

  src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8

  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 7eafe074b686d55ad96018006cf4acfa823513c3

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ad9126c32893080e128d086ea3bfd7ad23d27b89


Diff: https://reviews.apache.org/r/30010/diff/


Testing
-------

Added test for ConfigurationManager.hasName 
Added test testNoHostAndRackConstraintsAdded, that checks if the constraints are present
Tested on vagrant devcluster to see if constraints are also gone in "real life"


Thanks,

Florian Pfeiffer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message