aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 29915: Ensure TaskStateChange event emitted by StateManagerImpl has valid data.
Date Thu, 15 Jan 2015 23:14:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29915/#review68349
-----------------------------------------------------------

Ship it!


Master (1acb428) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 15, 2015, 9:32 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29915/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 9:32 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1016
>     https://issues.apache.org/jira/browse/AURORA-1016
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The `StateManagerImpl` class emits a pubsub event when a task transitions to the ASSIGNED
state but before it attaches the associated slave id and host. This patch ensures that the
pubsub event has the associated slave id and host when emitted.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1

>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42

> 
> Diff: https://reviews.apache.org/r/29915/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message