aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 29873: Fixing batched kill task filtering.
Date Wed, 14 Jan 2015 20:49:49 GMT


> On Jan. 14, 2015, 7:26 p.m., Bill Farner wrote:
> > > Also, dropped active instance validation from both updater calls as it was
hiding a legitimate feature: add new job instances with instance_spec.
> > 
> > I may have missed it - do unit tests verify this new behavior?
> 
> Maxim Khutornenko wrote:
>     The updater.py tests do. Since the functionality of validating instance spec is effectively
removed, I don't see much benefit adding tests to validate the absent feature.

I was probably too terse - you point out that you removed code because a legitimate use case
was heretofore impossible.  If that's the case, i'd like to make sure we have a test that
prevents me from dropping those lines back in and regressing behavior.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/#review68082
-----------------------------------------------------------


On Jan. 14, 2015, 1:16 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29873/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 1:16 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-996
>     https://issues.apache.org/jira/browse/AURORA-996
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixed job status quering in client context to return active tasks where needed.
> 
> Also, dropped active instance validation from both updater calls as it was hiding a legitimate
feature: add new job instances with instance_spec.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97

>   src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354

>   src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272

>   src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6

>   src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c

> 
> Diff: https://reviews.apache.org/r/29873/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello

>  INFO] Checking status of devcluster/www-data/prod/hello
>  INFO] 
> No tasks to kill found for job devcluster/www-data/prod/hello
> Job killall succeeded
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message