aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 29873: Fixing batched kill task filtering.
Date Wed, 14 Jan 2015 01:16:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-996
    https://issues.apache.org/jira/browse/AURORA-996


Repository: aurora


Description
-------

Fixed job status quering in client context to return active tasks where needed.

Also, dropped active instance validation from both updater calls as it was hiding a legitimate
feature: add new job instances with instance_spec.


Diffs
-----

  src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97

  src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354

  src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272

  src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6

  src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c


Diff: https://reviews.apache.org/r/29873/diff/


Testing
-------

./pants src/test/python:all

vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello 
 INFO] Checking status of devcluster/www-data/prod/hello
 INFO] 
No tasks to kill found for job devcluster/www-data/prod/hello
Job killall succeeded


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message