aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 29866: Upgrade pants to 0.0.27
Date Tue, 13 Jan 2015 23:11:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67967
-----------------------------------------------------------



build-support/python/make-pycharm-virtualenv
<https://reviews.apache.org/r/29866/#comment112054>

    We changed to src/test/python:: in the build script, but we're still using src/test/python:all
here. Should they be the same?



pants
<https://reviews.apache.org/r/29866/#comment112055>

    What if we have a file in the root like pants.version that's sourced by this and by update-pants-requirements
rather than having to keep the version in sync between the two?


- Joshua Cohen


On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 9:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0

>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27

>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789

>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c

> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message