aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 29828: Patch ResourceManager into OSS Aurora.
Date Tue, 13 Jan 2015 00:07:50 GMT


> On Jan. 12, 2015, 11:33 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/executor/common/resource_manager.py, lines 24-25
> > <https://reviews.apache.org/r/29828/diff/1/?file=818231#file818231line24>
> >
> >     Mind adding a TODO to drop the cpu and ram portions of this? Those are enforced
by mesos.
> 
> Brian Wickman wrote:
>     They're here for cpu_percent and ram_percent to be exported.  Does the mesos slave
export usage stats relative to reservation?
> 
> Kevin Sweeney wrote:
>     It doesn't, though it does export the raw metrics that make it possible. See https://issues.apache.org/jira/browse/MESOS-1458
for a discussion on why friendlier numbers are not exported.

OK then I'm inclined to keep them here for now.  Will add a TODO referencing MESOS-1458 which
we can then delete if MESOS-1458 is closed wontfix.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67743
-----------------------------------------------------------


On Jan. 12, 2015, 11:40 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29828/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1002
>     https://issues.apache.org/jira/browse/AURORA-1002
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch ResourceManager into OSS Aurora.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 0434c7ba480a80a9722e626775cf5c3adbc3e68e

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 9df9b4b79c0c7d29c5088409bf15c0d32a621df0

>   src/main/python/apache/aurora/executor/common/BUILD 142ec0d42b2cb31dcef1e32768e9ea5286355913

>   src/main/python/apache/aurora/executor/common/resource_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 2bf6b2df4761acaa88c38868f03e686ec6b42ab7

>   src/test/python/apache/aurora/executor/common/test_resource_manager.py PRE-CREATION

>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29828/diff/
> 
> 
> Testing
> -------
> 
> Ran e2e v1 tests which broke, but not because of the RM wiring.  Running e2e2 tests now.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message